[pve-devel] [PATCH storage] fix #3348: Revert "NFS: avoid using obsolete rpcinfo option"

Fabian Ebner f.ebner at proxmox.com
Wed Mar 17 10:46:58 CET 2021


This reverts commit 816dadb17f8e28d7a0a092c055c0c07b6038e64c.

With '-T' one needs to specify either 'tcp' or 'tcp6', and using 'tcp' doesn't
work for an IPv6-only server. Simply switch back to using '-t', because $server
might also just be a host name, so it's not really worth adding extra code (and
calls) to figure out if it's IPv4 or IPv6 beforehand.

Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
---

If preferred, I can send an alternative using
    rpcinfo -l $server nfs 4
but that requires parsing the output.

 PVE/Storage/NFSPlugin.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/Storage/NFSPlugin.pm b/PVE/Storage/NFSPlugin.pm
index cb16864..72e06c2 100644
--- a/PVE/Storage/NFSPlugin.pm
+++ b/PVE/Storage/NFSPlugin.pm
@@ -166,7 +166,7 @@ sub check_connection {
     if (defined($opts) && $opts =~ /vers=4.*/) {
 	# nfsv4 uses a pseudo-filesystem always beginning with /
 	# no exports are listed
-	$cmd = ['/usr/sbin/rpcinfo', '-T', 'tcp', $server, 'nfs', '4'];
+	$cmd = ['/usr/sbin/rpcinfo', '-t', $server, 'nfs', '4'];
     } else {
 	$cmd = ['/sbin/showmount', '--no-headers', '--exports', $server];
     }
-- 
2.20.1






More information about the pve-devel mailing list