[pve-devel] applied: [RFC/PATCH v2 container 5/5] vmstatus: make lock property optional again

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Mar 15 14:42:07 CET 2021


On 11.03.21 11:26, Fabian Ebner wrote:
> Commit d02262048cbbe91ca8b12f98e3dc7bbab28e4c64 made the property de-facto
> non-optional. Partially revert this and instead adapt the printing, making the
> behavior match the API description again. The conditional assignment is
> already there further down the vmstatus function.
> 
> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
> ---
> 
> New in v2.
> 
> Alternatively, the property description should be updated, but this patch makes
> it in line with what we do for VMs and is preferable IMHO.
> 

The schema is what our ABI is, so if that stated this is optional we can make
it so.

>  src/PVE/CLI/pct.pm | 3 ++-
>  src/PVE/LXC.pm     | 1 -
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, thanks!





More information about the pve-devel mailing list