[pve-devel] applied: [PATCH widget-toolkit 1/2] data/*Store: drop storeid requirement

[Thomas Lamprecht]

On 11.03.21 10:14, Dominik Csapak wrote:
> We never use that and it serves no purpose. It probably was meant
> to be the upstream config 'storeId' which would add the store to
> the Ext.StoreManager. This is unpractical though, since then the
> store has to be explicitely destroyed, otherwise the StoreManager
> retains a reference and the GC cannot remove the store.
> 
> Since donwstream users of the store can simply give the 'storeId'
> property anyway if they need to be managed by the StoreManager,
> drop the requirement here.
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> i tried to measure the memory impact of the StoreManager, but i did not
> find an easy way to deterministically find out. On average though,
> using 'storeId' everywhere, we retained a bit more memory (single
> digit percentage difference) as far as i could see.
> 
> but since we never actually use that functionality, i'd opt for
> not doing it by default and if we need it for a single store,
> do it manually (and then make sure the store gets removed again)
> 
> if we apply this, i can prepare patch series to remove the
> 'storeid's from pve/pmg/pbs
> 
>  src/data/ObjectStore.js | 4 ----
>  src/data/RRDStore.js    | 5 -----
>  src/data/UpdateStore.js | 3 ---
>  3 files changed, 12 deletions(-)
> 
>

applied, thanks!