[pve-devel] applied: [PATCH manager 7/7] ui: MachineEdit: add option for machine version pinning

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Mar 5 22:36:21 CET 2021


On 04.03.21 13:52, Stefan Reiter wrote:
> Hidden behind "Advanced" options, as to not confuse inexperienced users.
> 
> Signed-off-by: Stefan Reiter <s.reiter at proxmox.com>
> ---
>  www/manager6/qemu/MachineEdit.js | 69 ++++++++++++++++++++++++++++++++
>  1 file changed, 69 insertions(+)
> 
>

applied, and reworked quite a bit in followups.

General nit: please try to always keep the `xtype` property as first element in
a widget definition, to make it easier to see what widget it is (name/id/reference
should come after that, then label, then rest with listeners at the end - most of
our code even follows that style).





More information about the pve-devel mailing list