[pve-devel] applied: [PATCH v2 common] fix #3153: INotify: adding comment of interface to inet6 section when this is the only section

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Jun 28 15:03:09 CEST 2021

On 25.06.21 14:29, Lorenz Stechauner wrote:
> Signed-off-by: Lorenz Stechauner <l.stechauner at proxmox.com>
> ---
> changes to v1:
> * using delete instead of undef
> * added length check for families

You were right regarding the "inet6" only logic, but it should not hurt to make it
more specific either and having more limited assumptions (i.e., that the serializer
has the invariant of merging those comment properties) is often more robust, so I'd
have slightly preferred this variant, but just for the record as you went for the
"right" one anyway.

>  src/PVE/INotify.pm | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)

applied, thanks!

More information about the pve-devel mailing list