[pve-devel] [PATCH qemu-server] don't default to O_DIRECT on btrfs without nocow

Wolfgang Bumiller w.bumiller at proxmox.com
Thu Jun 24 17:03:23 CEST 2021

> On 06/24/2021 4:58 PM Wolfgang Bumiller <w.bumiller at proxmox.com> wrote:
> otherwise it'll produce a whole lot of checksum errors

Just a quick note that this can be more refined.

For one: it would be nice to have a `volume_has_feature` for this, but
for instance the directory storage plugin might not be able to determine
this properly at all, so I'm not sure how to really deal with this.
OTOH, for btrfs this really depends on whether the NOCOW flag was active
during the *creation* of the disk, so in the case of btrfs, the storage
can make a *better* decision there...


More information about the pve-devel mailing list