[pve-devel] applied: [PATCH storage 1/2] vdisk_list: only scan storages with the correct content type(s)

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Jun 21 11:22:36 CEST 2021

On 18.06.21 12:59, Fabian Ebner wrote:
> The enabled check in the lower loop is now redundant and can be removed.
> If storeid is provided, initialize the result hash accordingly, mainly for
> backwards compatibility (needed by a caller in pve-manager's Ceph/Pools.pm and
> the migration code in pve-container and qemu-server), but it also is less
> surprising in general.
> Remaining vdisk_list users that do not specify a content type are:
>     1. pve-manager's Pool/Ceph.pm, but the content type for RBD can only be
>        rootdir and images, so the storage is scanned (if enabled, same as
>        before).
>     2. pve-container migration
>     3. qemu-server migration
> For the latter two, it's planned to enforce content type, so the change is fine
> too.
> This also means that for iscsi(direct) plugins with content type 'none', i.e.
> "use LUNs directly" does not return the list of images anymore, but that was
> rather a bug anyways as they're not virtual disks then:
>     0.0.0.scsi-36001405b8f2772e13a04b8e9390db13d
> All of the remaining callers not using content types (see above) are fine with
> that change too.
> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
> ---
> Breaks old migration behavior when there are unused/unreferenced/vmstate volumes
> on a misconfigured storage!
>  PVE/Storage.pm | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)

applied, thanks!

More information about the pve-devel mailing list