[pve-devel] applied: [PATCH qemu-server 1/2] prefer storage_check_enabled over storage_check_node

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Jun 21 11:18:57 CEST 2021


On 18.06.21 12:59, Fabian Ebner wrote:
> storage_check_enabled simply checks for the 'disable' option and then calls
> storage_check_node.
> 
> While not strictly necessary for a second call where only the storage differs,
> e.g. in case of clone, it is more future-proof: if support for a target storage
> is added at some point, it might be easy to miss adapting the call.
> 
> For the migration checks, the situation is improved by now always catching
> disabled (target) storages.
> 
> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
> ---
>  PVE/API2/Qemu.pm   |  4 ++--
>  PVE/QemuMigrate.pm | 10 +++++-----
>  PVE/QemuServer.pm  |  4 ++--
>  3 files changed, 9 insertions(+), 9 deletions(-)
> 
>

applied, thanks!





More information about the pve-devel mailing list