[pve-devel] applied: [PATCH v5 container 0/4] post_clone_hook for containers

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Jun 18 18:18:26 CEST 2021


On 17.06.21 12:51, Oguz Bektas wrote:
> add post clone hook, and fix #3443 to clear machine-id for cloned
> containers
> 
> 
> v4->v5:
> * split patches for easy review/backport
> * also lock when moving config to target node
> * move create_and_lock_config outside the eval, this should be checked
> before the other ones
> 
> 
> Oguz Bektas (4):
>   setup: add post_clone_hook for containers
>   clone_vm: improve config locking
>   run post_clone_hook in clone_vm API
>   clone_vm: fix minor typo in error message
> 
>  src/PVE/API2/LXC.pm       | 55 +++++++++++++++++++++++++++------------
>  src/PVE/LXC/Setup.pm      | 12 +++++++++
>  src/PVE/LXC/Setup/Base.pm | 31 ++++++++++++++++++++++
>  3 files changed, 81 insertions(+), 17 deletions(-)
> 



applied with Fabians followups (thanks for those!), but it is still buggy then, i.e.,
- LXC::Setup post_clone_hook was just completely off
- if a (non-systemd) CT without any /etc/machine-id present gets cloned it suddenly
  gets an empty one?

so pushed out two followups to fix that mess...





More information about the pve-devel mailing list