[pve-devel] [PATCH v2 container 2/2] close #3471: Support for NetworkManager on CentOS.

[Fabian Grünbichler]

On June 17, 2021 2:28 pm, Dominik Csapak wrote:
> hi,
> 
> did not took a look at the whole patch, but
> some things stood out, comments inline
> 
> On 6/16/21 20:23, Denis Knauf wrote:
>> NetworkManager is used on RHEL8 and similar distributions like CentOS8,
>> AlmaLinux8 and RockyLinux8.
>> On RHEL7/CentOS7 it was not mandatory, but possible to use
>> NetworkManager.
>> The past config was used on CentOS6/7 withour NetworkManager, so tests
>> were also testing this basic network-config.
>> 
>> The patches is compatible to any RHEL7/RHEL8-compatible distribution with/without
>> NetworkManager.
>> 
>> Because the NetworkManager requires a UUID, the tests were extended by
>> special behaviour in case of UUIDs in `ifcfg-eth*`.
>> 
>> Successfully tested against:
>> * CentOS7 without NetworkManager
>> * CentOS7 with NetworkManager
>> * CentOS8
>> * RockyLinux 8
>> 
>> Signed-off-by: Denis Knauf <deac+git at denkn.at>

...

> 
>>   	my $data = '';
>>   	my $bootproto = '';
>>   
>> @@ -213,7 +214,7 @@ sub setup_network {
>>   	    if ($d->{ip6} eq 'auto') {
>>   		$data .= "IPV6_AUTOCONF=yes\n";
>>   	    }
>> -	    if ($d->{ip6} eq 'dhcp') {
>> +	    elsif ($d->{ip6} eq 'dhcp') {
> 
> this change does nothing?

it changes the condition for the else branch below (previously, ip6 == 
auto would take it, now it does not - see the bug report).

> 
>>   		$data .= "DHCPV6C=yes\n";
>>   	    } else {
>>   		$data .= "IPV6ADDR=$d->{ip6}\n";
>> @@ -229,6 +230,15 @@ sub setup_network {
>>   	    }
>>   	}