[pve-devel] [PATCH access-control v2] add missing paths in check_path

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Jun 16 16:27:54 CEST 2021


On 16.06.21 15:55, Dominik Csapak wrote:
> * /access/realm/<realm>
> * /access/groups/<group>
> 
> were overlooked when fixing #1500
> 
> see: https://forum.proxmox.com/threads/are-group-acls-broken-in-v6-4.91000/
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> supersedes my earlier patch:
> https://lists.proxmox.com/pipermail/pve-devel/2021-June/048704.html
> 
> changes:
> * also add missing group paths
> 
>  src/PVE/AccessControl.pm | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/PVE/AccessControl.pm b/src/PVE/AccessControl.pm
> index 888875e..9619c7d 100644
> --- a/src/PVE/AccessControl.pm
> +++ b/src/PVE/AccessControl.pm
> @@ -939,7 +939,9 @@ sub check_path {
>  	/
>  	|/access
>  	|/access/groups
> +	|/access/groups/[[:alnum:]\.\-\_]+
>  	|/access/realm
> +	|/access/realm/[[:alnum:]\.\-\_]+
>  	|/nodes
>  	|/nodes/[[:alnum:]\.\-\_]+
>  	|/pool
> 

also backported to stable-6, and those sub-paths are missing in the UI's
"path proposal" generator for the combobox's store, can you please send a
patch to add them there too (master only)?





More information about the pve-devel mailing list