[pve-devel] [PATCH v6 manager 7/7] fix #1710: ui: storage: add download from url button

[Dominic Jäger]

On Mon, May 17, 2021 at 10:03:18AM +0200, Lorenz Stechauner wrote:
> +		iso: [ > +		    'application/octet-stream',
> +		    'application/x-iso9660-image',
> +		    'application/x-ima',
When I try do download a Proxmox VE image I get type x-cd-image.
https://www.proxmox.com/en/downloads?task=callelement&format=raw&item_id=589&element=f85c494b-2b32-4109-b8c1-083cca2b7db6&method=download&args[0]=b9d30b3515e7a12dff5619ff1e1843be
Then the download button should not be deactivated.

> +	    advancedColumn1: [
> +		{
> +		    xtype: 'textfield',
> +		    name: 'checksum',
> +		    fieldLabel: gettext('Checksum'),
> +		    allowBlank: true,
> +		    disabled: true,
> +		    emptyText: gettext('none'),
> +		    id: 'downloadUrlChecksum',
> +		},
> +		{
> +		    xtype: 'pveHashAlgorithmSelector',
> +		    name: 'checksum-algorithm',
> +		    fieldLabel: gettext('Hash algorithm'),
> +		    allowBlank: true,
> +		    hasNoneOption: true,
> +		    value: '__default__',
> +		    listeners: {
> +			change: 'hashChange',
> +		    },
> +		},
An algorithm must be selected before entering something into the textfield.
Therefore, I'd place the algorithm selector above/before the textfield.
> +	    ],
> +	    advancedColumn2: [
> +		{
> +		    xtype: 'textfield',
> +		    fieldLabel: gettext('MIME type'),
> +		    name: 'mimetype',
> +		    disabled: true,
> +		    editable: false,
Non-editable might be good in general, but I cannot download the PVE image with
(unsupported) type x-cd-image because it will remain invalid forever.
> +		    emptyText: gettext('unknown'),
> +		    listeners: {
> +			change: 'typeChange',
> +		    },
> +		},
> +		{
> +		    xtype: 'proxmoxcheckbox',
> +		    name: 'verify-certificates',
> +		    fieldLabel: gettext('Verify certificates'),
> +		    uncheckedValue: 0,
> +		    checked: true,
> +		    listeners: {
> +			change: 'urlChange',
> +		    },
> +		},
> +	    ],
> +	},
> +    ],
> +

Downloading a Debian image and verifying with SHA512 worked for me
https://cdimage.debian.org/debian-cd/current/amd64/iso-dvd/debian-10.9.0-amd64-DVD-1.iso

Tested-by: Dominic Jäger <d.jaeger at proxmox.com>