[pve-devel] [PATCH-SERIES] Some breaking API changes/cleanups

[Fabian Ebner]

Of course all of the changes need to be recorded in the release notes.
Should I do so now or wait until the changes are actually applied?

Dependencies are noted on individual patches, most should apply independently.

There's still quite a few outstanding, but I feel like somebody with more
experience/context would be better suited to address them. I can go for another
round though if there are not enough volunteers ;)


pve-access-control:
src/PVE/Auth/AD.pm
30:         description => "Use secure LDAPS protocol. DEPRECATED: use 'mode' instead.",
src/PVE/Auth/LDAP.pm
390:    # FIXME: remove fallback with 7.0 by doing a rename on upgrade from 6.x

src/PVE/AccessControl.pm
299:    # FIXME: remove with PVE 7 and/or refactor all into PVE::Ticket ?

pve-common:
src/PVE/Ticket.pm
38:         # detected sha1 csrf token from older proxy, fallback. FIXME: remove with 7.0

pve-cluster:
quite a few // FIXME: remove openvz stuff for 7.x

pve-storage:
PVE/Storage/CephFSPlugin.pm
41:# FIXME: remove in PVE 7.0 where systemd is recent enough to not have those
# local-fs/remote-fs dependency cycles generated for _netdev mounts...


Would be glad if somebody experienced in those areas could look at them.



data/PVE/DataCenterConfig.pm has a few workarounds for deprecated options

pve-container:
src/PVE/LXC/Config.pm
652:    # Deprecated (removed with lxc 3.0):

src/PVE/LXC.pm
2178:   # FIXME: remove the 'id_map' variant when lxc-3.0 arrives


There might still be lxc/datacenter configs with the old options around?
Do we want to warn/replace as part of the pve6to7 script or just keep
the compat code longer?



pve-manager:
PVE/Ceph/Services.pm
54:     # FIXME: remove with 7.0 - for backward compat only

PVE/API2/Cluster/Ceph.pm
78:         # FIXME: remove with 7.0 depreacated by structured 'versions'


Front-end still expects the metadata.version to be present. Might not be hard to
adapt, but I didn't have the context to immediately know what's the right thing
to do. Can look at it if nobody else wants to.



pve-storage:
PVE/Storage.pm
966:    # FIXME PVE 7.0: only scan storages with the correct content types


>From an off-list discussion with Fabian G: We currently still need this behavior
to pick up disks from storages with a misconfigured content types. Meaning that
we need to require content type 'images' to be set first and warn people with
misconfigured storages as part of pve6to7. We could even go further and not pick
up unreferenced disks at all, but should expose rescan in the UI and make a
rescan as part of pve6to7. I will look at this in a separate series.



pve-guest-common:

Fabian Ebner (2):
  vzdump: remove deprecated size parameter
  vzdump: defaults: keep all backups by default for 7.0

 src/PVE/VZDump/Common.pm | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)


pve-container:

Fabian Ebner (1):
  migrate: remove deprecated force parameter

 src/PVE/API2/LXC.pm    | 6 ------
 src/PVE/LXC/Migrate.pm | 8 +-------
 2 files changed, 1 insertion(+), 13 deletions(-)


qemu-server:

Fabian Ebner (3):
  Revert "revert spice_ticket prefix change in 7827de4"
  scan volids: remove superfluous parameter
  vm destroy: do not remove unreferenced disks by default

 PVE/API2/Qemu.pm   | 5 ++---
 PVE/QemuMigrate.pm | 5 ++---
 PVE/QemuServer.pm  | 7 +++----
 3 files changed, 7 insertions(+), 10 deletions(-)


pve-storage:

Fabian Ebner (3):
  postinst: move cifs credential files into subdirectory upon update
  update reminder to remove maxfiles
  api: get rid of moved 'usb' call

 PVE/API2/Storage/Scan.pm  | 45 ---------------------------------------
 PVE/Storage.pm            |  2 +-
 PVE/Storage/CIFSPlugin.pm |  3 ---
 debian/postinst           | 30 ++++++++++++++++++++++++++
 4 files changed, 31 insertions(+), 49 deletions(-)
 create mode 100644 debian/postinst


novnc-pve:

Fabian Ebner (1):
  avoid passing deprecated 'upgrade' parameter

 ...passing-deprecated-upgrade-parameter.patch | 24 +++++++++++++++++++
 debian/patches/series                         |  1 +
 2 files changed, 25 insertions(+)
 create mode 100644 debian/patches/0014-avoid-passing-deprecated-upgrade-parameter.patch

pve-manager:

Fabian Ebner (12):
  vzdump: remove deprecated size parameter
  configs: vzdump: use prune-backups instead of the deprecated maxfiles
  test: vzdump: adapt to new default
  Revert "VZDump: add TARFILE to environment for hookscripts"
  api: nodes: remove deprecated upgrade parameter for xtermjs
  api: nodes: remove deprecated upgrade parameter for spiceshell
  api: nodes: remove deprecated upgrade parameter for vncshell
  api: move cpu path into qemu/capabilities
  api: ceph: remove obsoleted disks call
  api: ceph: remove moved 'flags' calls
  api: ceph: osd: create: rename size parameters
  cli: pveceph: remove outdated comment

 PVE/API2/Capabilities.pm              |   6 +
 PVE/API2/Ceph.pm                      | 178 --------------------------
 PVE/API2/Ceph/OSD.pm                  |   8 +-
 PVE/API2/Nodes.pm                     |  48 ++-----
 PVE/API2/VZDump.pm                    |   2 -
 PVE/CLI/pveceph.pm                    |   1 -
 PVE/VZDump.pm                         |   6 -
 configs/vzdump.conf                   |   3 +-
 test/vzdump_new_test.pl               |   8 +-
 www/manager6/ceph/OSD.js              |   8 +-
 www/manager6/form/CPUModelSelector.js |   2 +-
 11 files changed, 27 insertions(+), 243 deletions(-)

-- 
2.30.2