[pve-devel] applied-series: [PATCH-SERIES storage/widget-toolkit/manager] Add wipe disk api call and button

[Thomas Lamprecht]

On 23.04.21 12:14, Fabian Ebner wrote:
> widget-toolkit:
> 
> Fabian Ebner (4):
>   disk list: fix minor usage renderer issue
>   disk list: factor out renderer for type and usage
>   disk list: move title bar initialization to initComponent
>   disk list: add wipe disk button
> 
>  src/panel/DiskList.js | 223 ++++++++++++++++++++++++++++++------------
>  1 file changed, 161 insertions(+), 62 deletions(-)
> 
> 
> manager:
> 
> Fabian Ebner (2):
>   ui: add task description for wipe disk
>   ui: disk list: enable wipe disk button
> 
>  www/manager6/Utils.js       | 1 +
>  www/manager6/node/Config.js | 1 +
>  2 files changed, 2 insertions(+)
> 


applied the remaining patches.

Next things to do:

* enabled wiping for partitions
* hint that disks recognized as OSDs should use the OSD destroy dialogue if possible (i.e., if
  that disk is actually an OSD in the current cluster and all is still healthy enough for that)
* I'd change the top bar in general more like the OSD tree one, i.e., only reload left and the
  wipe/smart/init GPT buttons on the right with the selected disk text prefixed
* The confirm dialogue feels like it could get still some improvement about how to convey
  what will be destroyed more nicely, but as I do not have concrete proposals I just mention
  it for the sake of it, maybe someone else has better ideas.