[pve-devel] applied: Re: [PATCH pve-storage] fix #3555: BTRFSPlugin: call free_image correctly

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Jul 30 15:06:39 CEST 2021

On 30/07/2021 13:04, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer at proxmox.com>
> ---
>  PVE/Storage/BTRFSPlugin.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

applied, thanks! Albeit the commit message was lacking background, so I amended
it with:

> The method is only derived in the DirPlugin module from the base
> Plugin, so we do not have it available there through a static module
> method call using ::, but only when using a class dereference.
> Other fix options would have been:
>   PVE::Storage::Plugin::free_image(@_);
> or:
>   $class->SUPER::free_image($storeid, ...);

IMO, always helpful to have some background, it can help others learn something or
jump start such lousy brains like mine if they come over this in a few months again,
maybe even want to "optimize it back"; at least that's my experience with ours and
other projects source control trees, I never thought "wow, too much related info there
in the commit message" ;-)

More information about the pve-devel mailing list