[pve-devel] applied: Re: [PATCH v2 container] fix #3478: abort container creation on arch detection timeout

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Jul 29 17:51:43 CEST 2021


On 22/07/2021 09:54, Lorenz Stechauner wrote:
> increased the timeout for detect_arch from 5 to 10 seconds.
> 
> until now, on any error detect_architecture would fall back to amd64.
> to avoid falling back due to an timeout error this function now dies
> on timeout errors.
> 
> additionally minor changes to the error messages have been made.
> 
> Signed-off-by: Lorenz Stechauner <l.stechauner at proxmox.com>
> ---
> changes to v1:
> * implemented feedback
> * do not remove `\n` in error message
> 
>  src/PVE/LXC/Create.pm | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
>

applied, thanks!

Albeit I find the "why" behind just sketchy, if opening /bin/sh and reading 20 bytes
from it cannot be done in 5s something is seriously off IMO, but well, now they at
least get an actual error to point at that fact.





More information about the pve-devel mailing list