[pve-devel] [PATCH manager] api: apt: repos: fix interfacing with perlmod
Fabian Ebner
f.ebner at proxmox.com
Thu Jul 15 08:47:29 CEST 2021
Using
pvesh create /nodes/pve701/apt/repositories --path
"/etc/apt/sources.list" --index 0 --enabled 1
reliably leads to
error: invalid type: string "0", expected usize
Coerce to int to avoid this. I was not able to trigger the issue with
the "enabled" option here (in PMG I was), but be on the safe side and
coerce there too.
Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
---
Changes from v1:
* avoid creating an implicit default by checking definedness first
PVE/API2/APT.pm | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm
index bd60db33..310d875f 100644
--- a/PVE/API2/APT.pm
+++ b/PVE/API2/APT.pm
@@ -750,13 +750,16 @@ __PACKAGE__->register_method({
code => sub {
my ($param) = @_;
+ my $enabled = $param->{enabled};
+ $enabled = int($enabled) if defined($enabled);
+
my $options = {
- enabled => $param->{enabled},
+ enabled => $enabled,
};
PVE::RS::APT::Repositories::change_repository(
$param->{path},
- $param->{index},
+ int($param->{index}),
$options,
$param->{digest}
);
--
2.30.2
More information about the pve-devel
mailing list