[pve-devel] [PATCH] fix compressor loop-order

Stoiko Ivanov s.ivanov at proxmox.com
Wed Jul 14 18:52:04 CEST 2021

commit dbac106eb6e3cff405e57c0bb6a6dbe3cf307c52 introduced a flaw in
the logic - once a file is downloaded the 'last;' statement exited the
inner loop iterating over the compoentens instead of the outer one
iterating over the compressors.

since both do not inherently depend on each other simply swap them.

noticed while trying to build a pmg-template in a clean environment
with full repository configuration (before the tests worked due to
leftover files in the infodir)

Signed-off-by: Stoiko Ivanov <s.ivanov at proxmox.com>
Sorry for the inconvenience!

 DAB.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/DAB.pm b/DAB.pm
index b81321e..9282789 100644
--- a/DAB.pm
+++ b/DAB.pm
@@ -648,8 +648,8 @@ sub initialize {
 	    warn "Release info ignored\n";
-	foreach my $compressor (@$COMPRESSORS) {
-	    foreach my $comp (@{$ss->{comp}}) {
+	foreach my $comp (@{$ss->{comp}}) {
+	    foreach my $compressor (@$COMPRESSORS) {
 		$path = "dists/$ss->{suite}/$comp/binary-$arch/Packages.$compressor->{ext}";
 		$target = "$infodir/" . __url_to_filename ("$ss->{source}/$path");
 		my $pkgsrc = "$src/$path";

More information about the pve-devel mailing list