[pve-devel] [PATCH manager 1/2] pve6to7: storage content: skip scanning storage if shared

[Fabian Grünbichler]

On July 7, 2021 12:22 pm, Fabian Ebner wrote:
> Shared storages are not scanned for migration either, so they cannot
> be problematic in this context. This could lead to false positives
> where it actually is completely unproblematic:
> 
> https://forum.proxmox.com/threads/proxmox-ve-7-0-released.92007/post-401165

but the behaviour changes for shared storages as well? previously, 
vdisk_list would list regardless of content type settings, now it 
properly filters, so volumes on shared storage "disappear"..

> 
> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
> ---
>  PVE/CLI/pve6to7.pm | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/PVE/CLI/pve6to7.pm b/PVE/CLI/pve6to7.pm
> index 69ed6d2e..17da70e8 100644
> --- a/PVE/CLI/pve6to7.pm
> +++ b/PVE/CLI/pve6to7.pm
> @@ -707,6 +707,7 @@ sub check_storage_content {
>      for my $storeid (sort keys $storage_cfg->{ids}->%*) {
>  	my $scfg = $storage_cfg->{ids}->{$storeid};
>  
> +	next if $scfg->{shared};
>  	next if !PVE::Storage::storage_check_enabled($storage_cfg, $storeid, undef, 1);
>  
>  	my $valid_content = PVE::Storage::Plugin::valid_content_types($scfg->{type});
> -- 
> 2.20.1
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 
>