[pve-devel] applied: [PATCH storage] extract backup config: less precise matching for broken pipe detection

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Jul 6 17:49:10 CEST 2021

On 06.07.21 15:47, Fabian Ebner wrote:
> Extracting the config for zstd compressed vma files was broken:
>     Failed to extract config from VMA archive: zstd: error 70 : Write
>     error : cannot write decoded block : Broken pipe (500)
> since the error message changed and wouldn't match anymore.
> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
> ---
> Hotfix for now, isn't there a better way to properly handle this?

meh, properly handling it is a bit of a PITA and that's why we landed here,
which, short of style fixing in the output like with zstd here, served us
surprisingly well.

Properly would probably mean one of:
* make the vma tool understand the compressions, adding in quite some libraries
  for that single use case, so not too ideal..
* saving the config in some other way, e.g., outside of the archive, so that we
  either reverse the pipe direction (vma gets config blob and then decompresses
  it) or avoid compression for the, rather small config file completely
* adding a control fd to VMA where it can tell that it closed OK, that way we
  could ignore any error if we get an OK written from vma to that FD.
  That wouldn't sound to bad actually, but did not really thought it out..

>  PVE/Storage.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

for now that'll do, applied, thanks!

More information about the pve-devel mailing list