[pve-devel] [PATCH storage] cifs: fix adding storage without username in the GUI

[Stoiko Ivanov]

Currently when trying to add a CIFS storage, without providing a
username and passwort it fails while trying to mount the share, due to
the provided 'username=' parameter (w/o actual username).

I think the issue was introduced in
72385de9e23df9f8e438d74ff783a8075f8d1560
with the extracting of sensitive parameters we (rightly) switched to a
definedness check instead of one for truthyness - but an empty
username/password is defined.

Signed-off-by: Stoiko Ivanov <s.ivanov at proxmox.com>
---
 PVE/Storage/CIFSPlugin.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/PVE/Storage/CIFSPlugin.pm b/PVE/Storage/CIFSPlugin.pm
index 9d69b01..f8e173d 100644
--- a/PVE/Storage/CIFSPlugin.pm
+++ b/PVE/Storage/CIFSPlugin.pm
@@ -157,7 +157,7 @@ sub check_config {
 sub on_add_hook {
     my ($class, $storeid, $scfg, %param) = @_;
 
-    if (defined($param{password})) {
+    if (defined($param{password}) && $param{password}) {
 	cifs_set_credentials($param{password}, $storeid);
 	if (!exists($scfg->{username})) {
 	    warn "ignoring password parameter\n";
@@ -174,7 +174,7 @@ sub on_update_hook {
 
     return if !exists($param{password});
 
-    if (defined($param{password})) {
+    if (defined($param{password}) && $param{password}) {
 	cifs_set_credentials($param{password}, $storeid);
 	if (!exists($scfg->{username})) {
 	    warn "ignoring password parameter\n";
-- 
2.30.2