[pve-devel] [PATCH manager v2 2/2] pve6to7: add 'full' parameter for expensive checks

Stoiko Ivanov s.ivanov at proxmox.com
Mon Jul 5 12:57:17 CEST 2021


and place the container cgroupv2 support checks behind it.

Signed-off-by: Stoiko Ivanov <s.ivanov at proxmox.com>
---
 PVE/CLI/pve6to7.pm | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/PVE/CLI/pve6to7.pm b/PVE/CLI/pve6to7.pm
index b9aeb89c..5e97a3c5 100644
--- a/PVE/CLI/pve6to7.pm
+++ b/PVE/CLI/pve6to7.pm
@@ -1119,6 +1119,12 @@ __PACKAGE__->register_method ({
     parameters => {
 	additionalProperties => 0,
 	properties => {
+	    full => {
+		description => 'perform additional, expensive checks.',
+		type => 'boolean',
+		optional => 1,
+		default => 0,
+	    },
 	},
     },
     returns => { type => 'null' },
@@ -1131,6 +1137,12 @@ __PACKAGE__->register_method ({
 	check_storage_health();
 	check_misc();
 
+	if ($param->{full}) {
+	    check_containers_cgroup_compat();
+	} else {
+	    log_skip("Expensive checks not performed without 'full' parameter");
+	}
+
 	print_header("SUMMARY");
 
 	my $total = 0;
@@ -1153,7 +1165,4 @@ __PACKAGE__->register_method ({
 
 our $cmddef = [ __PACKAGE__, 'checklist', [], {}];
 
-# for now drop all unknown params and just check
- at ARGV = ();
-
 1;
-- 
2.30.2






More information about the pve-devel mailing list