[pve-devel] applied: [PATCH] ui: dc/Guests: make update lazy

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Jul 5 12:27:15 CEST 2021


Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
---
 www/manager6/dc/Guests.js | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)

diff --git a/www/manager6/dc/Guests.js b/www/manager6/dc/Guests.js
index 0707dd9f..df233b6d 100644
--- a/www/manager6/dc/Guests.js
+++ b/www/manager6/dc/Guests.js
@@ -118,8 +118,21 @@ Ext.define('PVE.dc.Guests', {
 
     updateValues: function(qemu, lxc, error) {
 	let me = this;
-	me.getComponent('qemu').update(qemu);
-	me.getComponent('lxc').update(lxc);
-	me.getComponent('error').update({ num: error });
+
+	let lazyUpdate = (query, newData) => {
+	    let el = me.getComponent(query);
+            let currentData = el.data;
+
+	    let keys = Object.keys(newData);
+	    if (keys.length === Object.keys(currentData).length) {
+		if (keys.every(k => newData[k] === currentData[k])) {
+		    return; // all stayed the same here, return early to avoid bogus regeneration
+		}
+	    }
+	    el.update(newData);
+	};
+	lazyUpdate('qemu', qemu);
+	lazyUpdate('lxc', lxc);
+	lazyUpdate('error', { num: error });
     },
 });
-- 
2.30.2






More information about the pve-devel mailing list