[pve-devel] applied: [PATCH pve-manager] ui: implement OpenId login

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Jul 2 15:13:31 CEST 2021

On 24.06.21 10:17, Dietmar Maurer wrote:
> ---
>  PVE/HTTPServer.pm                  |   4 +-
>  www/manager6/Utils.js              |   8 +++
>  www/manager6/window/LoginWindow.js | 105 ++++++++++++++++++++++++++++-
>  3 files changed, 114 insertions(+), 3 deletions(-)

applied, thanks!

just FYI:
I squashed in a few fixes though, for one the gettext usage was broken as
things like `gettext('' + variable)` cannot work (would never wind a translation)
and the scanner in proxmox-i18n cannot detect such things either.

One must use either `Ext.String.format((gettext("bla bla: {0}"), variable)` or add
the variable after the gettext call, depending on use-case.

Also factored out the `openid_login_param` helper to proxmox-widget toolkit
as `getOpenIDRedirectionAuthorization`, also fixed some casing (we prefer camelCase
over snake_case in JS for new code[0]).

[0]: https://pve.proxmox.com/wiki/Javascript_Style_Guide#Casing

More information about the pve-devel mailing list