[pve-devel] [PATCH manager] vzdump: avoid parsing already parsed option

Fabian Ebner f.ebner at proxmox.com
Fri Jan 15 13:49:05 CET 2021

When a job is updated, verify_vzdump_parameters() is called twice. This led to
parse_property_string being called with the already parsed option.

Reported on the pve-user mailing list:

Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>

The following patch is also necessary, for the cron file read/write:

 PVE/VZDump.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index d6f9709b..a99d0565 100644
--- a/PVE/VZDump.pm
+++ b/PVE/VZDump.pm
@@ -79,6 +79,7 @@ my $parse_prune_backups_maxfiles = sub {
         if defined($maxfiles) && defined($prune_backups);
     if (defined($prune_backups)) {
+	return if ref($prune_backups) eq 'HASH'; # already parsed
 	$param->{'prune-backups'} = PVE::JSONSchema::parse_property_string(

More information about the pve-devel mailing list