[pve-devel] [PATCH manager 2/2] Add tests for OSD-belongs-to-node helper

Dominic Jäger d.jaeger at proxmox.com
Mon Jan 11 12:42:59 CET 2021


Signed-off-by: Dominic Jäger <d.jaeger at proxmox.com>
---
 test/Makefile    |  5 +++-
 test/OSD_test.pl | 72 ++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 76 insertions(+), 1 deletion(-)
 create mode 100755 test/OSD_test.pl

diff --git a/test/Makefile b/test/Makefile
index d383e89f..3c4d2f2a 100644
--- a/test/Makefile
+++ b/test/Makefile
@@ -5,7 +5,7 @@ all:
 export PERLLIB=..
 
 .PHONY: check balloon-test replication-test mail-test vzdump-test
-check: test-replication test-balloon test-mail test-vzdump
+check: test-replication test-balloon test-mail test-vzdump test-osd
 
 test-balloon:
 	./balloontest.pl
@@ -27,6 +27,9 @@ test-vzdump-guest-included:
 test-vzdump-retention:
 	./vzdump_new_retention_test.pl
 
+test-osd:
+	./OSD_test.pl
+
 .PHONY: install
 install:
 
diff --git a/test/OSD_test.pl b/test/OSD_test.pl
new file mode 100755
index 00000000..df8c7881
--- /dev/null
+++ b/test/OSD_test.pl
@@ -0,0 +1,72 @@
+#!/usr/bin/perl
+
+use strict;
+use warnings;
+
+use lib ('.', '..');
+
+use JSON;
+use Test::More;
+use PVE::API2::Ceph::OSD;
+
+use Data::Dumper;
+
+my $tree = {
+    nodes => [
+	{
+	    id => -3,
+	    name => 'pveA',
+	    children => [ 0,1,2,3 ],
+	}, {
+	    id => -5,
+	    name => 'pveB',
+	    children => [ 4,5,6,7 ],
+	}, {
+	    id => -7,
+	    name => 'pveC',
+	    children => [ 8,9,10,11 ],
+	},
+    ],
+};
+
+
+# Check if all the grep and casts are correct
+my @belong_to_B = ( 4,5 );
+my @not_belong_to_B = ( -1,1,10,15 );
+foreach (@belong_to_B) {
+    is (
+	PVE::API2::Ceph::OSD::osd_belongs_to_node($tree, 'pveB', $_),
+	1,
+	"OSD $_ belongs to node pveB",
+    );
+}
+foreach (@not_belong_to_B) {
+    is (
+	PVE::API2::Ceph::OSD::osd_belongs_to_node($tree, 'pveB', $_),
+	0,
+	"OSD $_ does not belong to node pveB",
+    );
+}
+
+
+my $double_nodes_tree = {
+    nodes => [
+	{
+	    name => 'pveA',
+	},
+	{
+	    name => 'pveA',
+	}
+    ]
+};
+eval { PVE::API2::Ceph::OSD::osd_belongs_to_node($double_nodes_tree, 'pveA') };
+like($@, qr/not be more than one/, "Die if node occurs too often");
+
+my $tree_without_nodes = {
+    dummy => 'dummy',
+};
+eval { PVE::API2::Ceph::OSD::osd_belongs_to_node(undef) };
+like($@, qr/No tree nodes/, "Die if tree has no nodes");
+
+
+done_testing(@belong_to_B + @not_belong_to_B + 2);
\ No newline at end of file
-- 
2.20.1




More information about the pve-devel mailing list