[pve-devel] [PATCH manager 1/2] ui: firewall: Clarify group rule subjects
Dominic Jäger
d.jaeger at proxmox.com
Tue Jan 5 12:00:32 CET 2021
First, both buttons add a row to the grid, so they should be both "Add" (or both
"Insert").
Secondly, we add a (security group) rule to the grid, not the group itself.
Thirdly, the window title should be different to the regular rule.
Signed-off-by: Dominic Jäger <d.jaeger at proxmox.com>
---
www/manager6/grid/FirewallRules.js | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/www/manager6/grid/FirewallRules.js b/www/manager6/grid/FirewallRules.js
index 42035129..08deee2a 100644
--- a/www/manager6/grid/FirewallRules.js
+++ b/www/manager6/grid/FirewallRules.js
@@ -361,7 +361,7 @@ Ext.define('PVE.FirewallGroupRuleEdit', {
});
Ext.apply(me, {
- subject: gettext('Rule'),
+ subject: gettext('Group rule'),
isAdd: true,
items: [ ipanel ]
});
@@ -578,8 +578,7 @@ Ext.define('PVE.FirewallRules', {
if (me.allow_groups) {
me.groupBtn = Ext.create('Ext.Button', {
- text: gettext('Insert') + ': ' +
- gettext('Security Group'),
+ text: gettext('Add') + ': ' + gettext('Group rule'),
disabled: true,
handler: function() {
var win = Ext.create('PVE.FirewallGroupRuleEdit', {
--
2.20.1
More information about the pve-devel
mailing list