[pve-devel] applied: [PATCH common] network: get_local_ip_from_cidr: return unique IPs

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Feb 25 13:49:16 CET 2021


On 22.02.21 14:24, Fabian Ebner wrote:
> to avoid erroring out when "multiple" addresses are configured on live
> migration, when in fact it's the same IP multiple times.
> 
> Seems like the same problem for a caller in pve-cluster was fixed by checking
> the uniqueness afterwards, see commit 266041169beb36c8892ca54265e2d91335307ffb
> in pve-cluster. But there doesn't seem to be any caller relying on the current
> behavior, and no additional information other than the addresses are returned,
> so fix it here.
> 
> Reported here:
> https://forum.proxmox.com/threads/live-migration-of-vms-via-full-mesh-network-could-not-get-ip-multiple-addresses-configured-on-local-node-for-network.84585/
> 
> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
> ---
>  src/PVE/Network.pm | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
>

applied, thanks!

Follow'd up with ensuring the returned array is always sorted in a stable manner,
perl hash key pseudo random ordering is just a pain..




More information about the pve-devel mailing list