[pve-devel] applied: [PATCH v2 manager 4/4] ui: qemu/HardwareView: fix CDRom permission checkss

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Feb 19 17:32:37 CET 2021


On 12.02.21 16:57, Aaron Lauterer wrote:
> There are several types of drives that use the same config keys. Most
> notably CDRom and regular VM disks (EFI and cloudinit exist as well).
> 
> Since there is a dedicated permission for CDRom drives we need to check
> permissions in more detail, depending on what type of drive it actually
> is for things like the edit, remove and Add -> CDRom buttons.
> 
> The permission check in the row definition itself which only checked for
> 'VM.Config.Disk' permissions (never_delete) had to be removed and finer
> grained checks added for the individual buttons. This also meant a bit
> of reshuffling in the checks what kind of disk the current one is.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
> ---
> 
> v2: improved permission checks in the GUI to make sure that CDRom things
> will behave as expected and the other things are kept as is. Meaning all
> other disks (cloudinit, efi, used, unused) still need VM.Config.Disk
> permissions.
> 
> Tested by giving a user only VMAudit and Config.CDRom permissions in the
> one case, and all VM.Config.* permissions except CDRom.
> 
>  www/manager6/qemu/HardwareView.js | 24 ++++++++++++++++--------
>  1 file changed, 16 insertions(+), 8 deletions(-)
> 
>

applied, but prefixed with some further cleanups which result was merged
into this one, so maybe a re-check would be good.
much thanks!




More information about the pve-devel mailing list