[pve-devel] [PATCH-SERIES v2] loosen up mailto regex for backwards compatibility

Fabian Ebner f.ebner at proxmox.com
Wed Feb 17 12:42:03 CET 2021


On 17.02.21 11:35, Fabian Ebner wrote:
> On 17.02.21 10:52, Dominik Csapak wrote:
>> LGTM, nothing obvious that is wrong
>> one small thing though, after this patch i cannot
>> have an @ in the local part of an email anymore, though
>> i do not think that people actually use that?
>>
>> e.g. foo at bar@example.com does not work anymore
>>
> 
> Thanks for the review and for catching that! I'll send a follow-up (or 
> does this warrant a v3?) including '@' in the local part, and check that 
> other users of the 'email' format are not confused by that in some way.
> 

After a bit of discussion, I decided to not send that follow-up, because 
'@' is technically only valid in quoted strings (which we didn't/don't 
support here) and AFAICT we used the same 'email' format from pve-common 
in some parts of PMG without noticeable complaints.

>> Other than that, i tested it and worked as advertised
>>
>> Reviewed-By: Dominik Csapak <d.csapak at proxmox.com>
>>
>> On 2/15/21 13:24, Fabian Ebner wrote:
>>> especially regarding the whitespace-agnostic behavior. And while 
>>> we're at it,
>>> also use the more complete email regex from pve-common.
>>>
>>> Changes from v1:
>>>      * re-use the email regex from pve-common
>>>      * improve printing out mailto parameters to the cron file
>>>
>>>
>>> common:
>>>
>>> Fabian Ebner (2):
>>>    sendmail: use more complete email regex and shellquote
>>>    register email-or-username format
>>>
>>>   src/PVE/JSONSchema.pm | 14 +++++++++++++-
>>>   src/PVE/Tools.pm      | 17 ++++++++++++-----
>>>   2 files changed, 25 insertions(+), 6 deletions(-)
>>>
>>>
>>> guest-common:
>>>
>>> Fabian Ebner (3):
>>>    vzdump: command line: refactor handling prune-backups
>>>    vzdump: command line: make sure mailto is comma-separated
>>>    vzdump: mailto: use email-or-username-list format
>>>
>>>   PVE/VZDump/Common.pm | 14 +++++---------
>>>   1 file changed, 5 insertions(+), 9 deletions(-)
>>>
>>>
>>> manager:
>>>
>>> Fabian Ebner (3):
>>>    vzdump: refactor parsing mailto so it can be mocked
>>>    test: vzdump: add tests for mailto
>>>    test: vzdump: rename vzdump_new_retention_test.pl to
>>>      vzdump_new_test.pl
>>>
>>>   PVE/API2/VZDump.pm                            |  11 +-
>>>   PVE/VZDump.pm                                 |  21 +++
>>>   test/Makefile                                 |   8 +-
>>>   ...w_retention_test.pl => vzdump_new_test.pl} | 174 +++++++++++++++++-
>>>   4 files changed, 198 insertions(+), 16 deletions(-)
>>>   rename test/{vzdump_new_retention_test.pl => vzdump_new_test.pl} (74%)
>>>
>>
>>
>>
>> _______________________________________________
>> pve-devel mailing list
>> pve-devel at lists.proxmox.com
>> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>>
>>
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel




More information about the pve-devel mailing list