[pve-devel] [PATCH-SERIES v2] loosen up mailto regex for backwards compatibility

Dominik Csapak d.csapak at proxmox.com
Wed Feb 17 10:52:18 CET 2021


LGTM, nothing obvious that is wrong
one small thing though, after this patch i cannot
have an @ in the local part of an email anymore, though
i do not think that people actually use that?

e.g. foo at bar@example.com does not work anymore

Other than that, i tested it and worked as advertised

Reviewed-By: Dominik Csapak <d.csapak at proxmox.com>

On 2/15/21 13:24, Fabian Ebner wrote:
> especially regarding the whitespace-agnostic behavior. And while we're at it,
> also use the more complete email regex from pve-common.
> 
> Changes from v1:
>      * re-use the email regex from pve-common
>      * improve printing out mailto parameters to the cron file
> 
> 
> common:
> 
> Fabian Ebner (2):
>    sendmail: use more complete email regex and shellquote
>    register email-or-username format
> 
>   src/PVE/JSONSchema.pm | 14 +++++++++++++-
>   src/PVE/Tools.pm      | 17 ++++++++++++-----
>   2 files changed, 25 insertions(+), 6 deletions(-)
> 
> 
> guest-common:
> 
> Fabian Ebner (3):
>    vzdump: command line: refactor handling prune-backups
>    vzdump: command line: make sure mailto is comma-separated
>    vzdump: mailto: use email-or-username-list format
> 
>   PVE/VZDump/Common.pm | 14 +++++---------
>   1 file changed, 5 insertions(+), 9 deletions(-)
> 
> 
> manager:
> 
> Fabian Ebner (3):
>    vzdump: refactor parsing mailto so it can be mocked
>    test: vzdump: add tests for mailto
>    test: vzdump: rename vzdump_new_retention_test.pl to
>      vzdump_new_test.pl
> 
>   PVE/API2/VZDump.pm                            |  11 +-
>   PVE/VZDump.pm                                 |  21 +++
>   test/Makefile                                 |   8 +-
>   ...w_retention_test.pl => vzdump_new_test.pl} | 174 +++++++++++++++++-
>   4 files changed, 198 insertions(+), 16 deletions(-)
>   rename test/{vzdump_new_retention_test.pl => vzdump_new_test.pl} (74%)
> 





More information about the pve-devel mailing list