[pve-devel] applied: [PATCH qemu-server] qmeventd: explicitly close() pidfds

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Feb 11 17:17:27 CET 2021


On 09.02.21 16:24, Stefan Reiter wrote:
> In most circumstances a pidfd gets closed automatically once the child
> dies, and that *should* be guaranteed by us calling SIGKILL - however,
> it seems that sometimes that doesn't happen, leading to leaked file
> descriptors[0].
> 
> Also add a small note to verbose mode showing when the late-cleanup
> actually happens, helped during debug.
> 
> [0] https://forum.proxmox.com/threads/cannot-shutdown-vm.83911/
> 
> Signed-off-by: Stefan Reiter <s.reiter at proxmox.com>
> ---
> 
> I'm puzzled by this, and I'm not entirely sure this is the full fix, but it does
> seem like a good idea to close the fds explicitly anyway.
> 
>  qmeventd/qmeventd.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
>

applied, thanks!




More information about the pve-devel mailing list