[pve-devel] partially-applied: [PATCH-SERIES] partially fix #2285: extend Diskmanage to also list partitions

Fabian Ebner f.ebner at proxmox.com
Mon Feb 8 08:58:58 CET 2021


Am 06.02.21 um 14:13 schrieb Thomas Lamprecht:
> On 26.01.21 12:45, Fabian Ebner wrote:
>> and fix some other little things along the way (see patches #1, #4, #9).
>>
>> Mostly re-uses existing functionality, but refactors it, so it can be re-used
>> for partitions as well. New is the detection of filesystems via lsblk and the
>> detection of more PVE-relevant partuuids.
>>
>> In the UI, the current list is replaced by a treepanel including the partitions.
>>
>> This series does not yet make it possible to select partitons for storage
>> creation for certain types, which is one of the parts of bug #2285. I felt
>> like this series was getting rather big already and that there was more
>> discussion to be had about that and it can always be done as a follow-up series.
>> The usage of a partition currently always defaults to 'partition'. A good
>> heuristic to find out when a partition is unused would be needed and/or good
>> ways to warn the user and ask if they're sure they have the correct partition.
>> This also ties in to the proposed feature of allowing users to wipe disks under
>> certain conditions.
>>
> 
> 
> Applied storage and manager patches, thanks!
> 
> For widget toolkit I'm wondering about backward compatibility towards older
> API daemons still running and other products - you mentioned PBS so I guess
> you tested it?
> 

No, sorry, I missed this. Because of the new parameter in the API call 
it's not backwards compatible. I'll send a v2 for those patches and make 
sure it's backwards compatible.

> Also, the Type column for partitions shouldn't be "unknown" but rather
> "partition", or even "GPT Partition"/"MBR Partition" or the like.
> 

And I'll also add a patch for this.




More information about the pve-devel mailing list