[pve-devel] [PATCH manager 4/4] ui: snapshot: show task viewer for progress log

Fabian Ebner f.ebner at proxmox.com
Fri Feb 5 09:42:03 CET 2021


Am 04.02.21 um 13:52 schrieb Stefan Reiter:
> Signed-off-by: Stefan Reiter <s.reiter at proxmox.com>
> ---
>   www/manager6/window/Snapshot.js | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/www/manager6/window/Snapshot.js b/www/manager6/window/Snapshot.js
> index 2fa97041..a5fddd0f 100644
> --- a/www/manager6/window/Snapshot.js
> +++ b/www/manager6/window/Snapshot.js
> @@ -139,7 +139,8 @@ Ext.define('PVE.window.Snapshot', {
>   	if (me.isCreate) {
>   	    subject = (me.type === 'qemu' ? 'VM' : 'CT') + me.vmid + ' ' + gettext('Snapshot');
>   	    me.method = 'POST';
> -	    me.showProgress = true;
> +	    me.showProgress = !me.running;
> +	    me.showTaskViewer = me.running;

Nit: Should this be based on the 'vmstate' parameter instead? The task 
log for a running VM without including the state contains the same lines 
as for a shut down VM (those about the drives), so it feels a little 
inconsistent to show it in one situation, but not in the other.

>   	} else {
>   	    subject = `${gettext('Snapshot')} ${me.snapname}`;
>   	    me.url += `/${me.snapname}/config`;
> 




More information about the pve-devel mailing list