[pve-devel] [PATCH manager 3/7] ui: qemu/HardwareView: eslint: enforce "no-useless-concat" rule
Dominik Csapak
d.csapak at proxmox.com
Tue Feb 2 14:06:40 CET 2021
i'd prefer we use template strings if we touch this line
this could be
`/api2/json/nodes/${nodename}/qemu/${vmid}/pending`
On 2/1/21 3:21 PM, Aaron Lauterer wrote:
> Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
> ---
> www/manager6/qemu/HardwareView.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js
> index fa72d9d3..cc707a2a 100644
> --- a/www/manager6/qemu/HardwareView.js
> +++ b/www/manager6/qemu/HardwareView.js
> @@ -609,7 +609,7 @@ Ext.define('PVE.qemu.HardwareView', {
> };
>
> Ext.apply(me, {
> - url: '/api2/json/' + 'nodes/' + nodename + '/qemu/' + vmid + '/pending',
> + url: '/api2/json/nodes/' + nodename + '/qemu/' + vmid + '/pending',
> interval: 5000,
> selModel: sm,
> run_editor: run_editor,
>
More information about the pve-devel
mailing list