[pve-devel] [PATCH docs] pveproxy: improve LISTEN_IP doc

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Apr 28 13:51:51 CEST 2021


On 28.04.21 13:42, Oguz Bektas wrote:
>>> +
>>> + LISTEN_IP="fe80::d8ee:34ff:fe37:4579%vmbr0"
>>> +
>>> +After the change you have to restart `pveproxy` for it to take effect:
>>
>> I'd specifically state that a reload is not enough and then add a small warning that
>> a restart can stop some existing workers (not all, but e.g., shell connection is stopped
>> and reconnected which may loose info on CTs without a screen/tmux instance running).
>> Also, there's a short time window where no new connections are accepted IIRC (albeit
>> I was the one fixing that for reload it's been to long since then, so not sure anymore)
> 
> i think the phrasing "you have to restart" already emphasizes this,
> adding too many warnings or notes would just confuse users in my
> opinion.

No, it's clear that something needs to be restarted, but "restart" is a general
overused term which can mean lots of things (even reboot for some).

> 
> though i don't see any harm in making the **restart** bold in that
> sentence and adding that small warning about possible connection drop.

as said, restart is often used for the general semantic thing, be it reload or restart,
so this is really not clear. The gui also only triggers a reload, IIRC (pls. check)
and thus "restarting" (it's named that way there) from there would not help.

You just need to write it in such a way that it is not confusing, then it is not
a problem.




More information about the pve-devel mailing list