[pve-devel] applied: [PATCH manager] ui: set file name for spice console download in chrome

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Apr 23 15:30:35 CEST 2021


On 22.04.21 09:49, Lorenz Stechauner wrote:
> When the virt-viewer file is downloaded we already set
> a file name in Android, so the file type may be
> recognized. Also doing this in Chrome (and Chromium
> based browsers) allows users to "alyways open files of
> this type". So the browser automatically opens the
> console window without user interaction.
> 

note, this seems like a bit of a crammed commit message text-width wise.
I amended that to match the text-width = 69, as it should neither be overly
long, nor really short.

If you use vim for writing those I suggest adding a hunk like the following
to your vimrc:

au FileType gitcommit setlocal tw=69


> Signed-off-by: Lorenz Stechauner <l.stechauner at proxmox.com>
> ---
>  www/manager6/Utils.js | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
>

applied, thanks! Behavior is really better this way in Chrome/Chromium.
My Firefox here already worked fine, so seems not required for it anyway.




More information about the pve-devel mailing list