[pve-devel] [PATCH qemu-server] migrate: fix memory migration start time

Fabian Ebner f.ebner at proxmox.com
Fri Apr 23 14:31:40 CEST 2021


The variable is only ever used for calculating the average speed of memory
migration, but it was set before disk mirroring already. But the disk
sizes are not included in the calculation, resulting in (very) wrong values.

Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
---
 PVE/QemuMigrate.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
index 6455182..e9bcade 100644
--- a/PVE/QemuMigrate.pm
+++ b/PVE/QemuMigrate.pm
@@ -929,8 +929,6 @@ sub phase2 {
     $self->log('info', "start remote tunnel");
     $self->start_remote_tunnel($raddr, $rport, $ruri, $unix_socket_info);
 
-    my $start = time();
-
     if ($self->{storage_migration}) {
 	$self->{storage_migration_jobs} = {};
 	$self->log('info', "starting storage migration");
@@ -1025,6 +1023,8 @@ sub phase2 {
 
     }
 
+    my $start = time();
+
     $self->log('info', "start migrate command to $ruri");
     eval {
 	mon_cmd($vmid, "migrate", uri => $ruri);
-- 
2.20.1





More information about the pve-devel mailing list