[pve-devel] [RFC PATCH qemu-server] fix bootdisk_size for new bootorder config scheme
t.lamprecht at proxmox.com
Thu Apr 22 22:02:59 CEST 2021
On 08.03.21 14:43, Dominik Csapak wrote:
> Previously, we ever only had a single boot *disk*, while possibly
> having multiple cdroms/nics in the boot order
> e.g. the config:
> boot: dnc
> bootdisk: scsi0
> ide0: media=cdrom,none
> scsi0: xxx
> net0: ...
> would return the size of scsi0 even though it would first boot
> from cdrom/network.
> When editing the bootorder with such a legacy config, we
> remove the 'bootdisk' property and replace the legacy notation
> with an explicit order, but we only search the first disk
> for the size now.
> Restore that behaviour by iterating over all disks in the boot
> order property string until we get one that is not a cdrom
> and has a size.
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> i cannot remember if that change was deliberate, but at least one
> user ran into that:
@Stefan, can you, as main author behind the change in question, please give
this a review - thanks!
More information about the pve-devel