[pve-devel] applied: [PATCH manager] ui: firewall: rule: maxlength for source and dest

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Apr 22 21:34:49 CEST 2021


On 22.04.21 14:30, Aaron Lauterer wrote:
> Limiting the length of the source and dest paramters helps to avoid
> problems with iptables-restore which would not apply a rule if a
> parameter is larger than the parameter buffer (1024)[0]. As the API is
> already limiting this, we should also reflect that in the GUI and give
> people a hint that IP sets are most likely the better approach.
> 
> [0] http://git.netfilter.org/iptables/tree/iptables/xshared.c?h=v1.8.7#n469
> 
> Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
> ---
> This one "needs" the firewall patch 'fix #967: source: dest: limit length'
> 
> As always when it comes to messages, someone might have a better idea
> how to phrase the maxLengthText.
> 

good enough for me  :)

>  www/manager6/grid/FirewallRules.js | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
>

applied, thanks!




More information about the pve-devel mailing list