[pve-devel] [PATCH v2 00/13] Single-file-restore GUI for PBS snapshots

Stefan Reiter s.reiter at proxmox.com
Thu Apr 22 17:34:44 CEST 2021


Implements the necessary API for allowing single file restore via the PVE web
GUI.

This requires some adaptations of the HTTP server, to allow data streaming
without buffering - otherwise bigger restores would a) use up too much memory b)
get slowed down by the pvedaemon->pveproxy->client return path. Instead, we
transfer the data via a temporary FIFO.

Known issues/further work:
* restore VMs are not shown or stopped, they always run until timeout. Ideas
  would be to stop them when a user closes the restore window (but what if
  another user/tab/... is using the VM too?), or start a worker task for them
  (how to detect new VMs? parse proxmox-file-restore status before and after
  command?). Thoughts appreciated :)
* restarting the daemon or proxy marks the worker as failed and correctly
  stops it, but the browser says the download is OK - just with not enough data.
  Not the best experience, but unsure on how to fix this. Chunked encoding
  maybe, and terminate with an invalid chunk in case of error/abort?


v2:
* attach widget-toolkit patches, forgot them in v1
* drop patch "PBSClient: allow different command execution callback"
* drop applied patches, rebase
* nit cleanups from Fabian's preliminary review (thanks!)
  * includes API permission changes to keep them uniform for pve-storage
* fixups for Dominic's testing (thanks!)
* now supports encrypted CT and VM backups


proxmox-backup: Stefan Reiter (3):
  file-restore: don't force PBS_FINGERPRINT env var
  client-tools: add crypto_parameters_keep_fd
  file-restore: support encrypted VM backups

 src/bin/proxmox-file-restore.rs              | 22 +++++++++++++++++---
 src/bin/proxmox_client_tools/key_source.rs   | 17 +++++++++++++--
 src/bin/proxmox_file_restore/block_driver.rs |  1 +
 src/bin/proxmox_file_restore/qemu_helper.rs  | 12 ++++++-----
 4 files changed, 42 insertions(+), 10 deletions(-)

common: Stefan Reiter (4):
  PBSClient: adapt error message to include full package names
  PBSClient: add file_restore_list command
  PBSClient: add file_restore_extract function
  PBSClient: use crypt params for file 'list' and 'extract'

 src/PVE/PBSClient.pm | 71 ++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 69 insertions(+), 2 deletions(-)

http-server: Stefan Reiter (2):
  support streaming data form fh to client
  allow stream download from path and over pvedaemon-proxy

 PVE/APIServer/AnyEvent.pm | 145 +++++++++++++++++++++++++++++++++++---
 1 file changed, 137 insertions(+), 8 deletions(-)

storage: Stefan Reiter (1):
  add FileRestore API for PBS

 PVE/API2/Storage/FileRestore.pm | 160 ++++++++++++++++++++++++++++++++
 PVE/API2/Storage/Makefile       |   2 +-
 PVE/API2/Storage/Status.pm      |   6 ++
 3 files changed, 167 insertions(+), 1 deletion(-)
 create mode 100644 PVE/API2/Storage/FileRestore.pm

proxmox-widget-toolkit: Stefan Reiter (3):
  Utils: add errorCallback to monStoreErrors
  FileBrowser: support 'virtual'/'v' file type
  FileBrowser: show errors in messagebox and allow expand 'all'

 src/Utils.js              |  6 ++++--
 src/window/FileBrowser.js | 24 +++++++++++++++++++++---
 2 files changed, 25 insertions(+), 5 deletions(-)

-- 
2.20.1




More information about the pve-devel mailing list