[pve-devel] applied: [PATCH manager v2] ui: Utils: change default Console order for vms

[Dominik Csapak]

On 4/22/21 10:02, Thomas Lamprecht wrote:
> On 22.04.21 08:39, Dominik Csapak wrote:
>> we want to use spice for vms more than xtermjs if both are available
>> (since spice must be chosen as display in that case)
>> so the resulting order of preference for vms is:
>>    spice
>>    xtermjs
>>    novnc
>>
>> since all methods work for containers always, there we use
>> xtermjs by default, or what is chosen in the datacenter option
>>
>> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
>> ---
>> changes from v1:
>> * fixed the default so that it is only 'vv' for vms, not other
>>    types of consoles (shell, upgrade,..)
>>
>>   www/manager6/Utils.js | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>>
> 
> applied, thanks! But wondering if form VMs noVNC should be the next in line,
> as long as the display property of the VM is not set to a serialX console.
> 

could be nice, but would require adaptation in the status api call
(we only return if a serial terminal is there, not the vm config)