[pve-devel] applied-series: [PATCH manager v4 0/9] ceph: allow pools settings to be changed

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Apr 21 16:20:44 CEST 2021


On 20.04.21 10:15, Dominik Csapak wrote:
> originally from Alwin Antreich
> 
> mostly rebase on master, a few eslint fixes (squashed into alwins
> commits) and 3 small fixups
> 
> Alwin Antreich (6):
>   ceph: add autoscale_status to api calls
>   ceph: gui: add autoscale & flatten pool view
>   ceph: set allowed minimal pg_num down to 1
>   ceph: gui: rework pool input panel
>   ceph: gui: add min num of PG
>   fix: ceph: always set pool size first
> 
> Dominik Csapak (3):
>   API2/Ceph/Pools: remove unnecessary boolean conversion
>   ui: ceph/Pools: improve number checking for target_size
>   ui: ceph/Pool: show progress on pool edit/create
> 
>  PVE/API2/Ceph/Pools.pm    |  97 +++++++--
>  PVE/CLI/pveceph.pm        |   4 +
>  PVE/Ceph/Tools.pm         |  61 ++++--
>  www/manager6/ceph/Pool.js | 401 +++++++++++++++++++++++++++-----------
>  4 files changed, 422 insertions(+), 141 deletions(-)
> 



applied, thanks to both of you!

Made some followups on-top, besides some minor code style stuff it was mostly:
* avoid horizontal scrolling due to column width for 720p screens
* make min_size auto calculation (size + 1) / 2, so that size 4 gets min_size 3
* use the pveSizeField (adapted from the pveBandwidthField) for target size to
  avoid the *1024*1024*1024 for and back conversion in the panel get/setValues
* print pool settings as they're applied, makes a slightly nicer task log.




More information about the pve-devel mailing list