[pve-devel] applied: [PATCH storage] diskmanage: get_partnum: fix check

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Apr 20 18:13:29 CEST 2021


On 20.04.21 14:07, Fabian Ebner wrote:
> Not replacing it with return, because the current behavior is dying:
>     Can't "next" outside a loop block
> and the single existing caller in pve-manager's API2/Ceph/OSD.pm does not check
> the return value.
> 
> Also check for $st, which can be undefined in case a non-existing path was
> provided. This also led to dying previously:
>     Can't call method "mode" on an undefined value
> 
> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
> ---
>  PVE/Diskmanage.pm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
>

applied, thanks!




More information about the pve-devel mailing list