[pve-devel] applied: [PATCH qemu-server] drive: volume in-use check: fix fallback path comparison

Thomas Lamprecht t.lamprecht at proxmox.com
Sun Apr 18 18:00:10 CEST 2021


On 15.04.21 12:10, Fabian Ebner wrote:
> When checking whether a volume is still referenced by a snapshot, the void
> itself is first checked. When the volid is different, we fall back to comparing
> the path.
> 
> As the first value to be compared is a volume's path, the second value better be
> a volume's path too, and not a snapshot's path.
> 
> See also 77019edfe0c190c949cdc0b0e3b4ad2ca37313b3 for historical context.
> 
> The error that led me here:
> * had a VM with ZFS over iSCSI storage with an exsiting snapshot
> * add new unused drive
> * try to remove the unsued drive
> * fails, because ZFS (not Pool!) Plugin does not support snapshot paths.
> 
> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
> ---
>  PVE/QemuServer/Drive.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks! But see my other mail to this patch for a potential follow-up




More information about the pve-devel mailing list