[pve-devel] applied: [pbs-devel] [PATCH proxmox-backup 2/2] api/datastore: allow pxar file download of entire archive
t.lamprecht at proxmox.com
Tue Apr 13 08:39:19 CEST 2021
On 12.04.21 17:32, Stefan Reiter wrote:
> Treat filepaths like "/root.pxar.didx" without a trailing slash as
> wanting to download the entire archive content instead of erroring. The
> zip-creation code already works fine for this scenario.
> Signed-off-by: Stefan Reiter <s.reiter at proxmox.com>
> src/api2/admin/datastore.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
But that API is definitively weird in general...
1. old style API definition, should use the #[api()] macro instead
2. perly "params: Value", yeah, no thanks.
3. hard coded return stream type, one should be able to download also a single
file as zip, and we knew that we wanted .tar then too, so not providing an
param for that is weird.
4. accessed via /json/ path but never returns json
More information about the pve-devel