[pve-devel] applied: [PATCH storage 1/3] volume export/import: allow uppercase letters

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Apr 12 14:54:25 CEST 2021


On 12.04.21 13:37, Fabian Ebner wrote:
> Bug reported in the community forum[0].
> 
> Currently, it's possible to break replication by:
> 1. have an existing snapshot whose name contains an uppercase letter
> 2. set up a replication job and run it
> 3. rollback to the existing snapshot
> 4. replicate again -> fails
> 
> The failure occurs, because after step 3, the most recent common snapshot is the
> previously existing one and currently no uppercase letters are allowed for
> export/import.
> 
> The pve-snapshot-name option uses the CONFIGID_RE
>     qr/[a-z][a-z0-9_-]+/i
> so it cannot be used here, because it would not allow for e.g. '__migrate__'.
> Simply allow uppercase letters, to be backwards compatible and allow all
> possible pve-snapshot-name values.
> 
> There is still an issue if there also was state volume, but that's a different
> bug[1].
> 
> [0]: https://forum.proxmox.com/threads/solved-migration-error-base-value-does-not-match-the-regex-pattern.85946/
> [1]: https://bugzilla.proxmox.com/show_bug.cgi?id=3111
> 
> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
> ---
>  PVE/CLI/pvesm.pm | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
>

applied, thanks!

albeit with perl's extensice regex and the subtleties of unicode casing I'm not
always sure using the case-insensitive flag is the way to go, adding A-Z to the
allowed character set would be actually the smaller semantic change.

But it should not matter that much here, so I kept it as is for now...




More information about the pve-devel mailing list