[pve-devel] applied: [PATCH v2 storage] ZFS: mount subvols in activate_volume

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Sep 29 05:09:04 CEST 2020


On 28.09.20 11:48, Fabian Ebner wrote:
> Makes it possible to clone and start a container whose
> ZFS subvols are not yet mounted for some reason. If a
> subvol cannot be mounted, there's a better error now:
> zfs error: cannot mount '/myzpool/subvol-103-disk-0': directory is not empty
> 
> Previously, cloning would quietly do an "empty" clone,
> and startup would fail with:
> mount_autodev: 1074 Permission denied - Failed to create "/dev" directory
> lxc_setup: 3238 Failed to mount "/dev"
> do_start: 1224 Failed to setup container "103"
> __sync_wait: 41 An error occurred in another process (expected sequence number 5)
> 
> Signed-off-by: Fabian Ebner <f.ebner at proxmox.com>
> ---
> 
> Changes from v1:
>     * not a change in this patch, but important:
>       commit e8bb92bd2b1af95fd20db1b4aeb3dabc2811f571 moved volume activation
>       to vm_start, meaning that the mount operation introduced by this patch
>       does not happen (and fail) in the restricted apparmor context anymore
>     * adapt commit message to reflect current behavior (when the first version
>       was sent, starting failed quietly without producing an error)
>     * rebase against current master
> 
> Previous discussion:
> https://lists.proxmox.com/pipermail/pve-devel/2020-April/043088.html
> 
>  PVE/Storage/ZFSPoolPlugin.pm | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
>

applied, thanks!




More information about the pve-devel mailing list