[pve-devel] applied: [PATCH cluster] pmxcfs sync: properly check for corosync error

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Sep 25 15:23:06 CEST 2020


On 25.09.20 14:53, Fabian Grünbichler wrote:
> dfsm_send_state_message_full always returns != 0, since it returns
> cs_error_t which starts with CS_OK at 1, with values >1 representing
> errors.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> ---
> unfortunately not that cause of Alexandre's shutdown/restart issue, but
> might have caused some hangs as well since we would be stuck in
> START_SYNC in that case..
> 
>  data/src/dfsm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks! But as the old wrong code showed up as critical error
"failed to send SYNC_START message" if it worked, it either (almost) never
works here or is not a probable case, else we'd saw this earlier.

(still a valid and appreciated fix, just noting)





More information about the pve-devel mailing list