[pve-devel] applied: Re: [PATCH common] properly encode YAML via YAML::XS

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Sep 18 14:36:13 CEST 2020


On 9/17/20 1:16 PM, Fabian Grünbichler wrote:
> otherwise we get strange errors when formatting data that was originally
> JSON, and can thus contain JSON::true/JSON::false.
> 
> one example is the QMP query-blockstats command, which gets called (and
> the resulting values returned) by /nodes/NODE/qemu/VMID/status/current
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> ---
> 
> Notes:
>     alternatives include:
>     - dropping --output-format yaml altogether
>     - manually recursively mapping JSON::true/false to some sensible value before dumping
>     - outputting JSON instead of YAML, since the former is a subset of the latter (thanks Dominik ;))
>     
>     https://forum.proxmox.com/threads/yaml-issues-with-pvesh.76017/
> 
>  debian/control          | 1 +
>  src/PVE/CLIFormatter.pm | 7 ++++---
>  2 files changed, 5 insertions(+), 3 deletions(-)
> 
>

applied, thanks!





More information about the pve-devel mailing list